Template talk:Battle

From TheKolWiki
Jump to: navigation, search

Shouldn't this rather be called Template:Combat? It says Combat! in the game, too! Ukikatzi 14:45, 5 September 2006 (CDT)

  • {{Combat}} already exists, and it serves a completely different purpose. --Quietust 14:56, 5 September 2006 (CDT)
Oops, you got a point there. Ukikatzi


Moved discussion to Proposed Standards. --Quietust 10:03, 7 September 2006 (CDT)

I added a special move(s) parameter which can be seen at the Quiet Healer, but I wondering how conditional moves should be treated. Also, the NS has many special moves, which have some comments for each message. Also, this may apply to the way messages like the ball's are formatted.--Dehstil (t|c) 00:34, 8 March 2007 (CST)

Looking at the source and some other work, I notice that there's currently a link to Category:Test, essentially being used in place of something like Category:Missing message. Considering this seems to be fairly static, could someone just rename the category since it seems to work fine?--Toffile 01:09, 27 November 2008 (UTC)

In fact, looking at it, it seems that the Test category was marked for that test back in 2007.--Toffile 01:14, 27 November 2008 (UTC)
Simply changing it to Category:Incomplete instead of Test would seem appropriate. --Flargen 01:24, 27 November 2008 (UTC)
Probably. Unfortunately, page is locked, so an admin needs to do it.--Toffile 06:49, 28 November 2008 (UTC)
Wasn't locked enough to stop me, apparently. That's a first. --Flargen 06:57, 28 November 2008 (UTC)
Huh. Must've accidentally logged out when I checked it yesterday.--Toffile 07:05, 28 November 2008 (UTC)

It looks like an adjustment to the template is in order. The Crimbomination is so large that on my screen there's a huge bunch of whitespace between "The" and "Crimbomination". It seems to be aligning all text after the first line at the bottom of the image. Try using floats for the image and monster name? --Flargen 06:40, 1 January 2009 (UTC)

  • Doesn't seem anyone's noticed this but me so far. I've found a solution, though. It's kind of annoying, since CSS has difficulty with aligning text in one element to the middle of a neighboring element, but it can be done. If the part of the code that displays the image and text for the default case (|default=...) is replaced with the following, things should work:
<div style="display: table;">
[[image:{{data2|{{PAGENAME}}|image|{{{image}}}}}|{{data2|{{PAGENAME}}|name|{{{name}}}}}]]
<div style="display: table-cell; #position: absolute; #top: 50%; vertical-align: middle;">
<div style="#position: relative; #top: -50%; text-align: center; margin-left: 1em;">
You're fighting {{data2|{{PAGENAME}}|pronoun|{{{a}}}}} '''{{data2|{{PAGENAME}}|name|{{{name}}}}}'''
</div>
</div>
</div>
  • It also looks like the bolding of the monster name needs to be given a flag you can pass into the template to turn it off, since the Crimbomination doesn't have a bolded anything. --Flargen 06:36, 4 January 2009 (UTC)

Bolding

It seems bolding of the monster name has been turned off by default. This is wrong please fix the template. Discordance (talk) 09:50, 25 August 2013 (UTC)

  • You're fighting {{Data|{{PAGENAME}}|pronoun|{{{a}}}}} {{#if:{{Data|{{PAGENAME}}|displayname|}}|{{Data|{{PAGENAME}}|displayname}}|{{Data|{{PAGENAME}}|name|{{{name}}}}}}}
should be
  • You're fighting '''{{Data|{{PAGENAME}}|pronoun|{{{a}}}}} {{#if:{{Data|{{PAGENAME}}|displayname|}}|{{Data|{{PAGENAME}}|displayname}}|{{Data|{{PAGENAME}}|name|{{{name}}}}}}}'''

Discordance (talk) 21:22, 20 February 2015 (UTC)

    • Oops mafia was fixing the games lack of bolding? Oops! Discordance (talk) 21:45, 20 February 2015 (UTC)

Critical hits

Critical hits are now marked with (CRITICAL HIT!). Also, could we maybe have monsters without complete combat messages moved into another category? Category:Incomplete is cluttered with dozens of monsters like this which nobody seems to care about fixing (it's not exactly high-priority), and some of which can no longer be found. It would make it easier to find things which can be usefully fixed. —Yendor (talk) 02:52, 20 December 2014 (UTC)

  • Ok, I changed the autocat-ing to put them in Category:Missing Combat Messages instead (but give the wiki some time to fill it in). Adding (CRITICAL HIT!) is a bit trickier---it appears at the end of the message, before the {{ouch}}s, but that separation is not given in the message parameter passed to this template. So, we'd need to edit every monster and either manually add it in, or indicate to {{ouch}} to add it, or split up the critical hit message so this template can insert it in the right place. Alternatively, and much less work, but a bit hack-ish, we could modify the {{ouch}} template to always insert an invisible space (like the character between these quotes "​") at the beginning of its text, and then in this template use the string functions to find that character position and convert it into (CRITICAL HIT!) just for the critical hit message. --Fig bucket (talk) 16:37, 20 December 2014 (UTC)
    • Couldn't the template just add in the message after the actual critical message? If the issue is ouches, the template can auto-add those too. This also reminds me that we should probably change the hit parameter into hit1, hit2, etc up to hit6 to match in-game and then we can remove manually adding ouches entirely. It'd require a lot of work to update, but I think it would make the template cleaner. — Cool12309 (talk) 23:08, 20 December 2014 (UTC)
      • Yes, that would be a better way. As well as hit[1-6] and miss[1-6], we need hit[1-6]Element and criticalElement to accommodate elemental damage messages and change the ouches to brrrs for cold. An ouchLevel parameter to override a default number of ouches might be useful too. I tried it out on {{test}}. Note that this allows the old and new formats of the template to coexist during any transition period (although bot-ing the changes should also be possible). --Fig bucket (talk) 19:45, 30 December 2014 (UTC)

Batfellow Mobs

  • In Chrome, (Version 48.0.2564.82 m,) in the low-level mook the head is aligned left and the body centred. i'd post a screenshot but i have to go back to work. --Evilkolbot (talk) 13:30, 27 January 2016 (UTC)
    • I fiddled with the CSS for a while and still couldn't get it to align - but putting a small table around the mook image which seems to fix things. Let me know how that looks for other people. (Anyone with more knowledge of wiki formatting than me please feel free to fix.) --Aelfinn (talk) 15:12, 27 January 2016 (UTC)